Repository navigation
Preserve byte escapes when unquoting tokens - #484
Merged
Merged
Conversation
alecthomas
approved these changes
Sep 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unquote currently writes every decoded escape as a Unicode rune. Hexadecimal and octal byte escapes above 127 therefore change bytes:
"\xff"becomes UTF-8c3 bf, and"\xc3\xbf"becomesÿinstead ofÿ.Honor the multibyte result from strconv.UnquoteChar, preserving byte escapes while continuing to encode Unicode characters normally. Add public parser regressions covering byte, Unicode, mixed, and ASCII inputs.
Validation: four regressions fail before the fix. Full
go test -race ./..., all example tests, and the CI-pinned golangci-lint 2.12.2 pass with Go 1.26.6.